Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workbox-webpack-plugin comes with a wrong workbox-build version #11306

Closed
wants to merge 2 commits into from

Conversation

ikondrat
Copy link

@ikondrat ikondrat commented Aug 13, 2021

Hey everybody

workbox-webpack-plugin messed up the dependencies and installs uncompatible with workbox-webpack-plugin workbox-build

E.g.
workbox-webpack-plugin 6.1.5 requires workbox-build 6.1.5
But installs latest one which is 6.2.4 at the moment

It leads to the failing npm run start

Workarround
To lock workbox-build version as well for workbox-webpack-plugin

Other solution can be to use any kind of lock file (yarn, npm) for the react-scripts at least

@facebook-github-bot
Copy link

Hi @ikondrat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ikondrat
Copy link
Author

ikondrat commented Aug 13, 2021

@iansu I think it can be blocker for the 5.0 release as well 749a76d
because on the main branch workbox-build is also not fixed

@ikondrat ikondrat changed the title Wp5 fixed fix: fix issue with a wrong workbox-build version coming from workbox-webpack-plugin Aug 13, 2021
@ikondrat ikondrat changed the title fix: fix issue with a wrong workbox-build version coming from workbox-webpack-plugin fix: workbox-webpack-plugin comes with a wrong workbox-build version Aug 13, 2021
@raix
Copy link
Contributor

raix commented Aug 18, 2021

See #11293 and pr #11292

@ikondrat
Copy link
Author

@raix thanks a lot for the fixing

@ikondrat ikondrat closed this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants